What is Injection?
API's with the following properties are open to injection flaws:
- When we don't sanitize the input from the front-end we are opening ourselves to a world of problems, this would allow the user to input anything which could intervene with later processes.
- The same goes for validation and verification of the API's request, these have to be done before the data enters any kind of processes, this is where it could start causing problems for example on the login calls, make sure the API is validating, verifying and sanitizing any input.
- Make sure that you pay attention to not just the input from the user directly, this can also come from 3rd party services or file uploads for example.
- Take into account there might be processes such as batch jobs running that could trip over the data.
Example Attack Scenarios
I can also draw from experience on this vulnerability type as I have and reported on it often. The form I prefer is SQL injections via the import feature and OS command injection from an unexpected source. Let's start with the SQLi.
I found this issue while doing bug bounties on a private program and it happened because the developers did sanitise all the direct input very well, except they did not think to include the import functionality because the base of the application was built a year prior to building the import functionality.
Upload.csv looked like this:
And while uploading i selected the comma as field separator, this displayed a SQL error and from there on i dug in deeper.
The error was:
Expects parameter 1 to be string, null given in /var/www/html/import.php
This made me close the query and start a new one of my own
This made the application dump the entire users table in an error message, that was enough for me to report this issue and collect my bounty.
The second example i have is a little bit less complicated, i noticed a parameter literally called "osParam" which seemed to have some flags in it, i rushed to start up burp suite intruder with a list of command injections i had prepared before and had a hit on the 9th request that burp suite made. The command separate was a newline character '\n' and my ping command delayed the response.
So I quickly tried a whoami, reported the result and awaited approval which cames 2 days later.
Preventive measures against Injection vulnerabilities?
- We need to treat any input as being compromised and we should filter, validate and verify every input to our API through all ways, this includes third party inputs or non-direct inputs such as importing files.
- We have to make sure to create 1 system that will be able to perform these steps and that we implement and use that same system across all of our endpoints.
- Preferably use a well known library that has been tested instead of creating your own.
- We have to take care in filtering special characters, often the language we use has a specific syntax and way to handle these special characters and it's advised to implement that syntax.
- Whener multiple records are being selected, limit the number of records per query to avoid mass disclosure.
- Preferably use a specification that specifies how the API works such as OpenAPI and that you only allow requests that match the filters, verification and validation rules.
- Define what the API can expect for all the string endpoints and in terms of variable types.
An example in php which is badly implemented and leaves the app open for things such as XSS
This is how it's supposed to be done
This issue type is diverse and not always easy to automatically test, we have to keep a good overview of every endpoint, including the ones that are less obvious. Manual testing is still advised to complement the automated tests in areas where an automated test is falling short.
Taking every endpoint into account can be quite confusing as it includes finding all the hidden parameters as well. New API endpoints should already be added to the documentation and old endpoints should be indexed whenever possible.
According to statistics, we think that this vulnerability will be in the first place in the OWASP Top 10 in 2021.